Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

From: Andy Shevchenko
Date: Sun Apr 02 2017 - 16:18:48 EST


On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@xxxxxxxxx> wrote:
> Hi Andy,
>
> [auto build test ERROR on ljones-mfd/for-mfd-next]
> [also build test ERROR on v4.11-rc4 next-20170331]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

Thank you for report, though...

>
> url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/mfd-intel_soc_pmic-Fix-a-mess-with-compilation-units/20170320-153539
> base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
> config: tile-allyesconfig (attached as .config)
> compiler: tilegx-linux-gcc (GCC) 4.6.2
> reproduce:
> wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree

> make.cross ARCH=tile

...I doubt how below is related to my patch. This is obvious x86 code
which was initially submitted without
depend on X86
line in corresponding Kconfig.

>
> All errors (new ones prefixed by >>):
>
>>> drivers/mfd/intel_soc_pmic_bxtwc.c:24:31: fatal error: asm/intel_pmc_ipc.h: No such file or directory
> compilation terminated.
>
> vim +24 drivers/mfd/intel_soc_pmic_bxtwc.c
>
> 39d047c0 Qipeng Zha 2015-09-15 8 * version 2, as published by the Free Software Foundation.
> 39d047c0 Qipeng Zha 2015-09-15 9 *
> 39d047c0 Qipeng Zha 2015-09-15 10 * This program is distributed in the hope it will be useful, but WITHOUT
> 39d047c0 Qipeng Zha 2015-09-15 11 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> 39d047c0 Qipeng Zha 2015-09-15 12 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> 39d047c0 Qipeng Zha 2015-09-15 13 * more details.
> 39d047c0 Qipeng Zha 2015-09-15 14 */
> 39d047c0 Qipeng Zha 2015-09-15 15
> 39d047c0 Qipeng Zha 2015-09-15 16 #include <linux/module.h>
> 39d047c0 Qipeng Zha 2015-09-15 17 #include <linux/acpi.h>
> 39d047c0 Qipeng Zha 2015-09-15 18 #include <linux/err.h>
> 39d047c0 Qipeng Zha 2015-09-15 19 #include <linux/delay.h>
> 39d047c0 Qipeng Zha 2015-09-15 20 #include <linux/interrupt.h>
> 39d047c0 Qipeng Zha 2015-09-15 21 #include <linux/kernel.h>
> 39d047c0 Qipeng Zha 2015-09-15 22 #include <linux/mfd/core.h>
> 39d047c0 Qipeng Zha 2015-09-15 23 #include <linux/mfd/intel_bxtwc.h>
> 39d047c0 Qipeng Zha 2015-09-15 @24 #include <asm/intel_pmc_ipc.h>
> 39d047c0 Qipeng Zha 2015-09-15 25
> 39d047c0 Qipeng Zha 2015-09-15 26 /* PMIC device registers */
> 39d047c0 Qipeng Zha 2015-09-15 27 #define REG_ADDR_MASK 0xFF00
> 39d047c0 Qipeng Zha 2015-09-15 28 #define REG_ADDR_SHIFT 8
> 39d047c0 Qipeng Zha 2015-09-15 29 #define REG_OFFSET_MASK 0xFF
> 39d047c0 Qipeng Zha 2015-09-15 30
> 39d047c0 Qipeng Zha 2015-09-15 31 /* Interrupt Status Registers */
> 39d047c0 Qipeng Zha 2015-09-15 32 #define BXTWC_IRQLVL1 0x4E02
>
> :::::: The code at line 24 was first introduced by commit
> :::::: 39d047c0b1c812e9f0014e7100e372e61f2de3de mfd: add Intel Broxton Whiskey Cove PMIC driver
>
> :::::: TO: Qipeng Zha <qipeng.zha@xxxxxxxxx>
> :::::: CC: Lee Jones <lee.jones@xxxxxxxxxx>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation



--
With Best Regards,
Andy Shevchenko