Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's
From: Sathyanarayanan Kuppuswamy Natarajan
Date: Sun Apr 02 2017 - 21:54:26 EST
Thanks for your comments.
On Sun, Apr 2, 2017 at 6:58 AM, Andy Shevchenko
> On Sat, Apr 1, 2017 at 2:27 AM, Kuppuswamy Sathyanarayanan
> <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote:
>> This patch adds API's to read/write/update PMC GC registers.
>> PMC dependent devices like iTCO_WDT, Telemetry has requirement
will fix it in next version.
>> to acces GCR registers. These API's can be used for this
>> --- a/drivers/platform/x86/intel_pmc_ipc.c
>> +++ b/drivers/platform/x86/intel_pmc_ipc.c
>> +static inline int is_gcr_valid(u32 offset)
> Pointer to ipcdev should be a parameter to this function.
But ipcdev is a static variable, visible across this file. So there is
no point in passing it as parameter.
I just noticed that I am not holding the mutex lock in these
functions. I will fix it in next version.
>> + if (!ipcdev.has_gcr_regs)
>> + return -EACCES;
>> + if (offset > PLAT_RESOURCE_GCR_SIZE)
>> + return -EINVAL;
>> + return 0;
>> + * intel_pmc_gcr_update() - Update PMC GCR register bits
>> + * @offset: offset of GCR register from GCR address base
>> + * @mask: bit mask for update operation
>> + * @val: update value
>> + *
>> + * Updates the bits of given GCR register as specified by
>> + * mask and val
> -> * @mask and @val.
> You would need to refresh how to use kernel doc.
-:) will fix it in next version.
>> + *
>> + * Return: negative value on error or 0 on success.
>> + */
> With Best Regards,
> Andy Shevchenko