RE: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes

From: KY Srinivasan
Date: Tue Apr 04 2017 - 17:47:57 EST




> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas@xxxxxxxxxx]
> Sent: Tuesday, April 4, 2017 1:39 PM
> To: KY Srinivasan <kys@xxxxxxxxxxxxx>
> Cc: linux-pci@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx;
> vkuznets@xxxxxxxxxx; jasowang@xxxxxxxxxx;
> leann.ogasawara@xxxxxxxxxxxxx; marcelo.cerri@xxxxxxxxxxxxx; Stephen
> Hemminger <sthemmin@xxxxxxxxxxxxx>
> Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
>
> On Tue, Apr 04, 2017 at 07:54:33PM +0000, KY Srinivasan wrote:
> > > -----Original Message-----
> > > From: Bjorn Helgaas [mailto:helgaas@xxxxxxxxxx]
> > > Sent: Tuesday, April 4, 2017 12:04 PM
> > > To: KY Srinivasan <kys@xxxxxxxxxxxxx>
> > > Cc: linux-pci@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > > devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx;
> > > vkuznets@xxxxxxxxxx; jasowang@xxxxxxxxxx;
> > > leann.ogasawara@xxxxxxxxxxxxx; marcelo.cerri@xxxxxxxxxxxxx; Stephen
> > > Hemminger <sthemmin@xxxxxxxxxxxxx>
> > > Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
> > >
> > > On Fri, Mar 24, 2017 at 11:06:40AM -0700, kys@xxxxxxxxxxxxxxxxxxxxxx
> > > wrote:
> > > > From: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > > >
> > > > Some miscellaneous fixes.
> > > >
> > > > K. Y. Srinivasan (2):
> > > > pci-hyperv: Fix a bug in specifying CPU affinity
> > > > pci-hyperv: Fix an atomic bug
> > > >
> > > > drivers/pci/host/pci-hyperv.c | 13 +++++++++----
> > > > 1 files changed, 9 insertions(+), 4 deletions(-)
> > >
> > > I applied these with Long's reviewed-by to pci/host-hv for v4.12 with the
> > > following subject lines:
> > >
> > > PCI: hv: Specify CPU_AFFINITY_ALL for MSI affinity when >= 32 CPUs
> > > PCI: hv: Allocate interrupt descriptors with GFP_ATOMIC
> > >
> > Thank you.
> >
> > > There were two copies of [1/2], which makes this error-prone. I applied
> > > the second one that defines CPU_AFFINITY_ALL.
> >
> > Thanks again; sorry for the confusion.
> >
> > >
> > > They're both marked for stable, but without any clue about when the
> > > problems were introduced or how serious they are, I did not queue them
> for
> > > v4.11. If you want them in v4.11, please supply those additional details.
> >
> > I think these issues have been there since the driver got merged
> upstream.
> > I would want this to be applied against 4.11 as well. Let me know if I should
> resend
> > these patches.
>
> No need to resend, but I do need more details about what issues these fix
> and why they're more urgent than garden-variety bug fixes that are planned
> for v4.12. In general for-linus is for fixing problems we added during the
> merge window, or other high-priority, low-risk changes.

For sure I want to get this into 4.12. Since it fixes issues that have been there for a long time,
(including 4.11), it would be good to get it into 4.11 as well.

Regards,

K. Y
>
> Bjorn