Re: [PATCH V2 11/16] block, bfq: reduce idling only in symmetric scenarios

[Paolo Valente]

> Il giorno 31 mar 2017, alle ore 17:20, Bart Van Assche <bart.vanassche@xxxxxxxxxxx> ha scritto:
> 
> On Fri, 2017-03-31 at 14:47 +0200, Paolo Valente wrote:
>> +       entity->weight_counter = kzalloc(sizeof(struct bfq_weight_counter),
>> +                                        GFP_ATOMIC);
>> +       entity->weight_counter->weight = entity->weight;
> 
> GFP_ATOMIC allocations are more likely to fail than GFP_KERNEL allocations.
> What will happen if kzalloc() returns NULL?
> 

A plain crash :( I'm adding the simple handling of this forgotten exception. If I don't get other reviews in the next days, I'll post a V3 addressing this and the other issue you highlighted.

Thanks,
Paolo

> Bart.