Re: [PATCH] char: misc: minor code cleanup

From: Greg Kroah-Hartman
Date: Sat Apr 08 2017 - 12:11:58 EST


On Mon, Feb 27, 2017 at 11:27:58PM +0100, Martin Kaiser wrote:
> Fix a couple of minor issues found by checkpatch.pl:
>
> Add/remove spaces where required.
> Move EXPORT_SYMBOL() to the end of the function it refers to.
> Set the access mode for the proc entry explicity.
> Use pr_warn() instead of printk() without loglevel.

Always break up patches to only do 1 thing per patch.

thanks,

greg k-h