Re: [PATCH v4 2/2] crypto: hw_random - Add new Exynos RNG driver

From: Herbert Xu
Date: Mon Apr 10 2017 - 06:56:50 EST


On Sat, Apr 08, 2017 at 03:32:45PM +0200, Krzysztof Kozlowski wrote:
>
> +static struct rng_alg exynos_rng_alg = {
> + .generate = exynos_rng_generate,
> + .seed = exynos_rng_seed,
> + .seedsize = EXYNOS_RNG_SEED_SIZE,
> + .base = {
> + .cra_name = "exynos_rng",

Please use stdrng. Or is there a reason why this can't be used
by the crypto layer itself?

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt