Re: [PATCH 4.9 000/152] 4.9.22-stable review

From: Tony Lindgren
Date: Tue Apr 11 2017 - 11:17:15 EST


* Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> [170410 21:45]:
> On Mon, Apr 10, 2017 at 08:07:17PM -0700, Guenter Roeck wrote:
> > The arm builds fail as follows.
> >
> > Building arm:overo:omap2plus_defconfig:omap3-overo-tobi ... failed
> > ------------
> > Error log:
> > In file included from arch/arm/mach-omap2/pdata-quirks.c:15:0:
> > arch/arm/mach-omap2/pdata-quirks.c:537:49: error: 'rx51_ir_data' undeclared here (not in a function)
> > OF_DEV_AUXDATA("nokia,n900-ir", 0, "n900-ir", &rx51_ir_data),
> > ^
> > ./include/linux/of_platform.h:52:21: note: in definition of macro 'OF_DEV_AUXDATA'
> > .platform_data = _pdata }
> > ^
> > make[1]: *** [arch/arm/mach-omap2/pdata-quirks.o] Error 1
> >
> > I am a bit lost here. Reverting
> >
> > f2ea7a5c3730 rx51: broken build
> >
> > fixes the problem, but is supposed to accomplish the opposite. You'll need to drop
> > that patch, or maybe even better drop

Just trying to understand what's going on.. OK so dropping the patch
above makes sense. It seems there's some other dependency not mentioned
there.

> > 375a81645446 ARM: OMAP2+: Fix init for multiple quirks for the same SoC
> >
> > as well and let the authors [copied] sort this out.

Guenter, what's your reasoning to also drop this one? I don't quite see
the connection between these two patches?

> Good idea, both now dropped, thanks.

Fine with me, the second one can always be revisited as needed.

Regards,

Tony