Re: [PATCH v3] HID: asus: support backlight on USB keyboards

From: Carlo Caione
Date: Wed Apr 12 2017 - 16:14:07 EST


On Wed, Apr 12, 2017 at 10:12 PM, Jiri Kosina <jikos@xxxxxxxxxx> wrote:
> On Wed, 12 Apr 2017, Carlo Caione wrote:
>
>> >> + ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev);
>> >> + if (ret < 0) {
>> >> + /* No need to have this still around */
>> >> + devm_kfree(&hdev->dev, drvdata->kbd_backlight);
>> >> + cancel_work_sync(&drvdata->kbd_backlight->work);
>> >
>> > Small nitpick, you don't need to call cancel_work_sync() here, nobody
>> > could have called a worker. But OTOH, it doesn't hurt.
>> >
>> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
>>
>> Thanks Benjamin. Who should pick this up?
>
> I am going to.
>
> I'll drop the cancel_work_sync() call while doing it, ok?

Sure, go for it.

Thank you,

--
Carlo Caione | +39.340.80.30.096 | Endless