Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all

From: Vincent Legoll
Date: Fri Apr 14 2017 - 08:47:02 EST


On Fri, Apr 14, 2017 at 2:32 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> That's fine, but you aren't actually changing the functionality of any
> of the build options here. You are just adding a 'menu' and showing
> things a bit differently.

Yes exactly, I did not intend to change functionality, only ease disabling
options, by not having to enter the menu. I.e. nothing much, especially
for this one where the new now-unconfigurable menu will only have a
single config entry inside (in fact I assumed there would be more coming)

That's why I let it stay inside a menu, and not straight removing the menu
and moved the config option one level up...

> You aren't changing any dependancies (which
> is what dictates what is and is not built), which does not make it
> easier, or harder, to disable/enable anything here.

I think I don't understand what you're telling here, I added a dep to ANDROID
for the ANDROID_BINDER_IPC config entry.

> I'm not against this, but you need to explain it a lot better as to what
> you are doing and why. The "why" isn't covered by the "this will make
> the kernel build smaller", as that's just not true :)

This is not intended to make the kernel build smaller, but to ease the tedious
process of going through "make menuconfig" and disabling all the options you
don't need.

The quantity of options has greatly increased, and when I could do a minimal
kernel config in a few minutes years ago, I now have to take tens of minutes
going through all. This work is a step trying to make this step quicker.

Is that better ?

Thanks

--
Vincent Legoll