Re: [patch V2 08/10] timer: Implement the hierarchical pull model

From: Peter Zijlstra
Date: Wed Apr 19 2017 - 03:21:05 EST


On Tue, Apr 18, 2017 at 01:11:10PM +0200, Thomas Gleixner wrote:
> +++ b/kernel/time/timer.c

> @@ -185,6 +186,10 @@ EXPORT_SYMBOL(jiffies_64);
> #define WHEEL_SIZE (LVL_SIZE * LVL_DEPTH)
>
> #ifdef CONFIG_NO_HZ_COMMON
> +/*
> + * If multiple bases need to be locked, use the base ordering for lock
> + * nesting, i.e. lowest number first.
> + */
> # define NR_BASES 3
> # define BASE_LOCAL 0
> # define BASE_GLOBAL 1

You already used that in previous patches, should this comment go there?