Re: [PATCH 1/2] hp-wmi: Fix error value for hp_wmi_tablet_state

From: Andy Shevchenko
Date: Wed Apr 19 2017 - 12:21:31 EST


On Sun, Apr 9, 2017 at 4:56 PM, Carlo Caione <carlo@xxxxxxxxxx> wrote:
> From: Carlo Caione <carlo@xxxxxxxxxxxx>
>
> hp_wmi_tablet_state() fails to return the correct error code when
> hp_wmi_perform_query() returns the HP WMI query specific error code
> that is a positive value.

> int ret = hp_wmi_perform_query(HPWMI_HARDWARE_QUERY, 0, &state,
> sizeof(state), sizeof(state));
> if (ret)
> - return ret;
> + return -EINVAL;

Shouldn't be something like

if (ret)
return ret < 0 ? ret : -EINVAL;

Looking into the code it looks like it may return all possible values:
0, negative, positive.

--
With Best Regards,
Andy Shevchenko