Re: [PATCH perf/urgent] perf tools: Fix the code to strip command name

From: Taeung Song
Date: Thu Apr 20 2017 - 06:42:42 EST




On 04/20/2017 07:35 PM, Jiri Olsa wrote:
On Thu, Apr 20, 2017 at 07:17:34PM +0900, Taeung Song wrote:
Hi Jiri,

On 04/20/2017 06:24 PM, Jiri Olsa wrote:
Recent commit broke command name strip in perf_event__get_comm_ids
function. It replaced left to right search for '\n' with rtrim,
which actually does right to left search. It occasionally caught
earlier '\n' and kept trash in the command name.

Sorry for my commit that have failings.

Could I know the command name in the above case ?
The command name can have two '\n' ?

it's the next line in the status file.. parts of the Umask string
and 1 newline

Name: systemd
Umask: 0000
State: S (sleeping)
...

I've already posted it in here:
http://marc.info/?l=linuxppc-embedded&m=149200723316270&w=2

jirka


I understood it.
Sorry for my mistake..

Thanks,
Taeung