re: mtip32xx: add a status field to struct mtip_cmd

[Colin Ian King]

Hi,

CoverityScan found an issue with the following part of the patch:

-       if (likely(!reserv))
-               blk_mq_complete_request(rq, -ENODEV);
-       else if (test_bit(MTIP_PF_IC_ACTIVE_BIT, &dd->port->flags)) {
+       if (likely(!reserv)) {
+               cmd->status = -ENODEV;
+               blk_mq_complete_request(rq, 0);
+       } else if (test_bit(MTIP_PF_IC_ACTIVE_BIT, &dd->port->flags)) {


The issue is:

static void mtip_no_dev_cleanup(struct request *rq, void *data, bool reserv)
{
        struct driver_data *dd = (struct driver_data *)data;
        struct mtip_cmd *cmd;

        if (likely(!reserv)) {
                cmd->status = -ENODEV;

CID 1430258 (#1 of 1): Uninitialized pointer write (UNINIT)4.
uninit_use: Using uninitialized value cmd.

..basically a null ptr dereference on cmd.

Colin