Re: [PATCH] lightnvm: propagate pblk_init return to userspace

From: Jens Axboe
Date: Fri Apr 21 2017 - 14:41:34 EST


On 04/21/2017 12:11 PM, Matias Bjørling wrote:
> On 04/21/2017 05:07 PM, Javier González wrote:
>>> On 20 Apr 2017, at 20.23, Rakesh Pandit <rakesh@xxxxxxxxxx> wrote:
>>>
>>> From userspace calling ioctl(NVM_DEV_CREATE) was returning ENOMEM for
>>> invalid arguments even though pblk (pblk_init) was returning correctly
>>> -EINVAL to nvm_create_tgt inside core. This patch propagates the
>>> correct return value to userspace.
>>>
>>> Because pblk was introduced recently this only needs to go in 4.12.
>>>
>>> Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target")
>>> Signed-off-by: Rakesh Pandit <rakesh@xxxxxxxxxx>
>>>
>>
>> Looks good.
>>
>> Reviewed-by: Javier González <javier@xxxxxxxxxxxx>
>>
>> Javier
>>
>
>
> Jens, would you pick this up as well? :)

Done, thanks Rakesh.

--
Jens Axboe