Re: [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

[Lukasz Luba]

Hi Viresh,

I was out of office.
I run your v3 (from git) with some basic tests.
IPA does not work, at least v3 does not crash the kernel.
I didn't have time to go through the patches to narrow down
the problem.

If you would like to run some basic test,
you can find it here [1].

I am happy to check v4 when it is ready.

Best regards,
Lukasz

[1] 
https://github.com/ARM-software/lisa/blob/master/ipynb/thermal/ThermalSensorCharacterisation.ipynb

On 19/04/17 06:22, Viresh Kumar wrote:
> On 18-04-17, 15:40, Lukasz Luba wrote:
> > Hi Viresh,
> >
> > I have checkout your branch at newest commit:
> > 908063832c268f8add94
> > I have built it and run it on my Juno r2.
> > I have some python tests for IPA and I run one of them.
> >
> > I seen a few issues so I have created a patch just
> > to be able to run IPA.
> > My next email will have the patch so you can see the changes.
> >
> > IPA does not work with this patch set.
> > I have tested two source codes from your repo:
> > 1. your change 908063832c268f8add94
> > 2. your base 8f506e0faf4e2a4a0bde9f9b1
> >
> > In case 1. IPA does not work - temperature rises to 83degC
> > in case 2. works - temperature is limited to 65degC.
>
> Yeah, there were some cases power specific cases that weren't covered in my
> tests and thanks a lot for testing it out. I have pushed my branch again and it
> has all your fixes (a bit refined) in it.
>
> > On Monday I can allocate more time for it.
>
> My branch should just work now. Please see if you can allocate 10-15 min today
> to give it a try, so that we can get it in earlier. I will send a V3 today and
> your Tested-by would be very much appreciated.
>
> Thanks Lukasz.