Re: [PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq sched_entities

From: Peter Zijlstra
Date: Mon Apr 24 2017 - 17:49:13 EST


On Mon, Apr 24, 2017 at 02:35:28PM -0700, Tejun Heo wrote:
> - if (se->avg.last_update_time && !(flags & SKIP_AGE_LOAD)) {
> - __update_load_avg(now, cpu, &se->avg,
> - se->on_rq * scale_load_down(se->load.weight),
> - cfs_rq->curr == se, NULL);
> + if (entity_is_task(se)) {
> + if (se->avg.last_update_time && !(flags & SKIP_AGE_LOAD))
> + __update_load_avg(now, cpu, &se->avg,
> + se->on_rq * scale_load_down(se->load.weight),
> + cfs_rq->curr == se, NULL);

I've not looked at these patches yet, but you've been patching old code.
__update_load_avg() no longer exists (the conversion shouldn't be too
hard, its mostly been a restructure/rename thing).