Re: [PATCH 3/3] HSI: omap_ssi: Delete an error message for a failed memory allocation in ssi_add_controller()

From: Dan Carpenter
Date: Tue Apr 25 2017 - 08:33:36 EST


1) That allocation will never fail in real life so it's dead code.
2) kmalloc and friends already have much better builtin in error
messages so it's useless.
3) There is a small memory savings from removing it.

I'm not saying you should apply the patch, I'm just saying that these
messages are pointless and detrimental.

regards,
an carpenter