Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the cygnus core DT.

[Sergei Shtylyov]

Hello!

On 04/25/2017 06:15 PM, Jon Mason wrote:

> > > Cygnus has a single amac controller connected to the B53 switch with 2
> > > PHYs.  On the BCM911360_EP platform, those two PHYs are connected to
> > > the external ethernet jacks.

[...]

> > > Signed-off-by: Eric Anholt <eric@xxxxxxxxxx>
> > > ---
> > >  arch/arm/boot/dts/bcm-cygnus.dtsi      | 60
> > > ++++++++++++++++++++++++++++++++++
> > >  arch/arm/boot/dts/bcm911360_entphn.dts |  8 +++++
> > >  2 files changed, 68 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
> > > b/arch/arm/boot/dts/bcm-cygnus.dtsi
> > > index 009f1346b817..318899df9972 100644
> > > --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> > > +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
[...]
> > > @@ -295,6 +345,16 @@
> > >                         status = "disabled";
> > >                 };
> > >
> > > +               eth0: enet@18042000 {
> > > +                       compatible = "brcm,amac";
> > > +                       reg = <0x18042000 0x1000>,
> > > +                             <0x18110000 0x1000>;
> > > +                       reg-names = "amac_base", "idm_base";
> >
> >
> >    I don't think "_base" suffixes are necessary here.
>
> 100% necessary, per the driver.  See
> drivers/net/ethernet/broadcom/bgmac-platform.c

   I'd recommend to fix the driver/bindings then...

MBR, Sergei