Re: [tip:x86/boot] x86/boot/e820: Basic cleanup of e820.c

From: Yinghai Lu
Date: Tue Apr 25 2017 - 20:10:29 EST


On Tue, Apr 11, 2017 at 12:37 AM, tip-bot for Ingo Molnar
<tipbot@xxxxxxxxx> wrote:
> Commit-ID: 640e1b38b00550990cecd809021cd37716e45922
> Gitweb: http://git.kernel.org/tip/640e1b38b00550990cecd809021cd37716e45922
> Author: Ingo Molnar <mingo@xxxxxxxxxx>
> AuthorDate: Sat, 28 Jan 2017 11:13:08 +0100
> Committer: Ingo Molnar <mingo@xxxxxxxxxx>
> CommitDate: Sat, 28 Jan 2017 14:42:27 +0100
>

> x86/boot/e820: Basic cleanup of e820.c
....
> @@ -951,49 +924,42 @@ void __init finish_e820_parsing(void)
> static const char *__init e820_type_to_string(int e820_type)
> {
> switch (e820_type) {
> - case E820_RESERVED_KERN:
> - case E820_RAM: return "System RAM";
> - case E820_ACPI: return "ACPI Tables";
> - case E820_NVS: return "ACPI Non-volatile Storage";
> - case E820_UNUSABLE: return "Unusable memory";
> - case E820_PRAM: return "Persistent Memory (legacy)";
> - case E820_PMEM: return "Persistent Memory";
> - default: return "reserved";
> + case E820_RESERVED_KERN: /* Fall-through: */
> + case E820_RAM: return "System RAM";
> + case E820_ACPI: return "ACPI Tables";
> + case E820_NVS: return "ACPI Non-volatile Storage";
> + case E820_UNUSABLE: return "Unusable memory";
> + case E820_PRAM: return "Persistent Memory (legacy)";
> + case E820_PMEM: return "Persistent Memory";
> + default: return "Reserved";
> }
> }
>
...

Hi Ingo,

The reserved ==> Reserved change cause kexec warning.

Unknown type (Reserved) while parsing /sys/firmware/memmap/18/type.
Please report this as bug. Using RANGE_RESERVED now.
Unknown type (Reserved) while parsing /sys/firmware/memmap/16/type.
Please report this as bug. Using RANGE_RESERVED now.
Unknown type (Reserved) while parsing /sys/firmware/memmap/14/type.
Please report this as bug. Using RANGE_RESERVED now.
Unknown type (Reserved) while parsing /sys/firmware/memmap/22/type.
Please report this as bug. Using RANGE_RESERVED now.
Unknown type (Reserved) while parsing /sys/firmware/memmap/9/type.
Please report this as bug. Using RANGE_RESERVED now.
add_buffer: base:43fff6000 bufsz:80e0 memsz:a000
add_buffer: base:43fff1000 bufsz:44ce memsz:44ce
add_buffer: base:43c000000 bufsz:f4c5c0 memsz:3581000
add_buffer: base:439d0d000 bufsz:22f2060 memsz:22f2060
add_buffer: base:43fff0000 bufsz:70 memsz:70
add_buffer: base:43ffef000 bufsz:230 memsz:230
10:~/k # cat /sys/firmware/memmap/14/type
Reserved

also /proc/iomem have that changed too.

Yinghai