Re: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask

From: Linus Walleij
Date: Wed Apr 26 2017 - 10:26:30 EST


On Mon, Apr 24, 2017 at 9:15 PM,
<sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote:

> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
>
> According to Whiskey Cove PMIC spec, bit 7 of GPIOIRQ0_REG belongs to
> battery IO. So we should skip this bit when checking for GPIO IRQ pending
> status. Otherwise, wcove_gpio_irq_handler() might go into the infinite
> loop until IRQ "pending" status becomes 0. This patch fixes this issue.
>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>

Looks fine to me, tentatively applied.

Bin, Mika, Andy, OK?

Yours,
Linus Walleij