Re: [PATCH] usb: host: xhci: remove #ifdef around PM functions

From: Greg Kroah-Hartman
Date: Wed Apr 26 2017 - 16:57:25 EST


On Fri, Apr 21, 2017 at 11:42:54PM +0200, Arnd Bergmann wrote:
> The #ifdef is slightly wrong as it doesn't cover the xhci_priv_resume_quirk()
> function, causing a harmless warning:
>
> drivers/usb/host/xhci-plat.c:58:12: error: 'xhci_priv_resume_quirk' defined but not used [-Werror=unused-function]
> static int xhci_priv_resume_quirk(struct usb_hcd *hcd)
>
> A simpler way to do this correctly is to use __maybe_unused annotations
> that let the compiler silently drop the functions when there is no
> reference.
>
> Fixes: b0c69b4bace3 ("usb: host: plat: Enable xHCI plat runtime PM")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/usb/host/xhci-plat.c | 12 ++++--------
> drivers/usb/host/xhci.h | 5 -----
> 2 files changed, 4 insertions(+), 13 deletions(-)

Now applied, thanks.

greg k-h