Re: [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage

From: David Howells
Date: Fri Apr 28 2017 - 11:47:53 EST


Mehmet Kayaalp <mkayaalp@xxxxxxxxxxxxxxxxxx> wrote:

> >> + /* TODO: update CRC */
> >
> > Is this bit missing?
>
> I didn't add it, since I wasn't sure it was still used with secure boot.

I'm not sure why secure boot would skip it if normal boot does it. You'll
have to trawl the boot wrapper and kernel arch setup code to answer that one.

> The CRC code is implemented in multiple places, but not exposed to the
> tools/scripts. Should I make the crc32() in tools/pcmcia/crc32hash.c
> non-static, maybe?

Making it non-static won't help since it's a standalone program. You could
just shift it to scripts or something.

David