Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free
From: Minchan Kim
Date: Tue May 02 2017 - 01:02:42 EST
On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote:
> In fact, during the test, I found the overhead of sort() is comparable
> with the performance difference of adding likely()/unlikely() to the
> "if" in the function.
This discussion is started from your optimization code:
if (nr_swapfiles > 1)
I don't have such fast machine so cannot test it. However, you added
such optimization code in there so I guess it's *worth* to review so
with spending my time, I pointed out what you are missing and
suggested a idea to find a compromise.
Now you are saying sort is so fast so no worth to add more logics
to avoid the overhead?
Then, please just drop that if condition part and instead, sort