Re: [PATCH v2 1/2] mm: Uncharge poisoned pages
From: Michal Hocko
Date: Tue May 02 2017 - 14:55:15 EST
On Tue 02-05-17 16:59:30, Laurent Dufour wrote:
> On 28/04/2017 15:48, Michal Hocko wrote:
> > This is getting quite hairy. What is the expected page count of the
> > hwpoison page?
OK, so from the quick check of the hwpoison code it seems that the ref
count will be > 1 (from get_hwpoison_page).
> > I guess we would need to update the VM_BUG_ON in the
> > memcg uncharge code to ignore the page count of hwpoison pages if it can
> > be arbitrary.
> Based on the experiment I did, page count == 2 when isolate_lru_page()
> succeeds, even in the case of a poisoned page.
that would make some sense to me. The page should have been already
unmapped therefore but memory_failure increases the ref count and 1 is
> In my case I think this
> is because the page is still used by the process which is calling madvise().
> I'm wondering if I'm looking at the right place. May be the poisoned
> page should remain attach to the memory_cgroup until no one is using it.
> In that case this means that something should be done when the page is
> off-lined... I've to dig further here.
No, AFAIU the page will not drop the reference count down to 0 in most
cases. Maybe there are some scenarios where this can happen but I would
expect that the poisoned page will be mapped and in use most of the time
and won't drop down 0. And then we should really uncharge it because it
will pin the memcg and make it unfreeable which doesn't seem to be what
we want. So does the following work reasonable? Andi, Johannes, what do
you think? I cannot say I would be really comfortable touching hwpoison
code as I really do not understand the workflow. Maybe we want to move
this uncharge down to memory_failure() right before we report success?