Re: [PATCH 2/2] kbuild: remove initramfs cpio with mrproper

[Masahiro Yamada]

Hi Stephen,


2017-04-15 6:54 GMT+09:00 Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>:
> When 'make mrproper' is done, it should also remove the initramfs cpio
> file. I ran into this while doing test build on one machine, followed
> by make mrproper and rsync to a target machine. The build on the target
> machine would succeed but be unbootable because of the bad initramfs.


I think initramfs_data.cpio.* is unneeded for external modules.

So, shouldn't it removed by 'make clean', instead of 'make mrproper'?




> Signed-off-by: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>
> ---
>  Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 04ca211552f7..954292695bf6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1276,7 +1276,8 @@ MRPROPER_FILES += .config .config.old .version .old_version \
>                   Module.symvers tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \
>                   certs/signing_key.pem certs/signing_key.priv certs/signing_key.x509   \
>                   certs/x509.genkey certs/extra_certificates certs/signing_key.x509.keyid \
> -                 certs/signing_key.x509.signer vmlinux-gdb.py
> +                 certs/signing_key.x509.signer vmlinux-gdb.py \
> +                 usr/initramfs_data.cpio.gz
>

As you see usr/Makefile,
datafile_y = initramfs_data.cpio$(suffix_y)

The suffix could be .gz, .bz2, .xz, etc.


Why only initramfs_data.cpio.gz?



-- 
Best Regards
Masahiro Yamada