Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check if battery is present

From: H. Nikolaus Schaller
Date: Wed May 03 2017 - 08:20:58 EST



> Am 01.05.2017 um 13:26 schrieb Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx>:
>
> Hi,
>
> On Fri, Apr 14, 2017 at 09:29:38PM +0200, H. Nikolaus Schaller wrote:
>> We can't assume that the battery is or stays present after probing
>> on devices with replaceable battery.
>>
>> On some devices (e.g. GTA04 or OpenPanodra) it can be removed
>> and even be hot swapped by the user while device continues to operate
>> through external AC or USB power (as long as system power consumption
>> remains below ca. 500mA as provided by USB). Under certain conditions
>> it is possible to boot without battery.
>>
>> So it makes no sense to check for this situation during probe and make
>> the charger driver (and its status reports) completely non-operational if
>> the battery can be inserted later.
>>
>> Tested on: GTA04 and OpenPandora.
>>
>> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
>
> Thanks, queued.

TNX,
Nikolaus

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail