Re: [PATCH v3 3/3] drivers:power:twl4030-charger: remove nonstandard max_current sysfs attribute

From: H. Nikolaus Schaller
Date: Wed May 03 2017 - 08:23:42 EST


Hi,

> Am 01.05.2017 um 13:26 schrieb Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx>:
>
> Hi,
>
> On Fri, Apr 14, 2017 at 08:25:57PM +0200, H. Nikolaus Schaller wrote:
>> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
>
> I'm not queuing this. Please change the following things for the
> v4 of this patch:
>
> - Kernel patches should always have a long description

Ok.

> - Patch needs to update Documentation/ABI/testing/sysfs-class-power-twl4030

Ok, forgot about this.

> - Make sure to use recent MAINTAINERS file for getting patch
> destination (Dmitry and David are no longer listed).
> - And for this case: please also Cc NeilBrown <neil@xxxxxxxxxx>. If
> the ABI is in use we cannot simply remove it. If its unlikely,
> that its used I will queue the patch and revert if any problems
> are reported.

Well, Neil did also work for the GTA04 project, so it is the same project.
But I will add him for V4 so that he can comment himself.

>
> -- Sebastian


BR and thanks,
Nikolaus

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail