Re: [PATCH 3/9] VFS: Introduce a mount context

From: David Howells
Date: Wed May 03 2017 - 16:11:28 EST


Joe Perches <joe@xxxxxxxxxxx> wrote:

> > > krealloc would probably be more efficient and possible
> > > readable as likely there's already padding in the original
> > > allocation.
> >
> > The problem is if krealloc() fails: you've lost all those pointers to things
> > you then need to free.
>
> Huh? How could that happen?
>
> krealloc must always use a temporary.
> If krealloc returns NULL, the original allocation is kept.

Hmmm... Good point.

David