[PATCH 3.12 33/86] char: lack of bool string made CONFIG_DEVPORT always on
From: Jiri Slaby
Date: Thu May 04 2017 - 05:18:37 EST
From: Max Bires <jbires@xxxxxxxxxx>
3.12-stable review patch. If anyone has any objections, please let me know.
commit f2cfa58b136e4b06a9b9db7af5ef62fbb5992f62 upstream.
Without a bool string present, using "# CONFIG_DEVPORT is not set" in
defconfig files would not actually unset devport. This esnured that
/dev/port was always on, but there are reasons a user may wish to
disable it (smaller kernel, attack surface reduction) if it's not being
used. Adding a message here in order to make this user visible.
Signed-off-by: Max Bires <jbires@xxxxxxxxxx>
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
drivers/char/Kconfig | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 0070872c1441..a961133e2aa2 100644
@@ -567,9 +567,12 @@ config TELCLOCK
controlling the behavior of this hardware.
+ bool "/dev/port character device"
depends on ISA || PCI
+ Say Y here if you want to support the /dev/port device. The /dev/port
+ device is similar to /dev/mem, but for I/O ports.