Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts()

From: Jani Nikula
Date: Fri May 05 2017 - 01:52:01 EST


On Thu, 04 May 2017, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> On Thu, May 04, 2017 at 06:54:16PM +0200, SF Markus Elfring wrote:
>> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>> Date: Thu, 4 May 2017 13:20:47 +0200
>>
>> Some strings which did not contain data format specifications should be put
>> into a sequence. Thus use the corresponding function "seq_puts".
>
> debugfs / seq_file is not performance critical. Familiar idiomatic code is
> much preferred over continually switching between seq_printf and seq_puts.
>
> And don't even start on converting seq_printf / seq_puts to seq_putc...

Agreed. I don't want any of the seq_* changes in this series.

BR,
Jani.

--
Jani Nikula, Intel Open Source Technology Center