Re: [PATCH] [RFC] of/platform: Make of_dev_node_match() helper public
From: Rob Herring
Date: Fri May 05 2017 - 14:51:24 EST
On Fri, May 5, 2017 at 9:52 AM, Geert Uytterhoeven
> Several drivers provide their own match functions, identical to
> of_dev_node_match() in the OF platform core.
> Reduce duplication by making of_dev_node_match() public.
> To avoid conflicts, the duplicates in coresight and i2c must be removed
> at the same time.
I think you are down one level too far. At least the 2 users here are
just for calls to bus_find_device. We already have a function for that
with of_find_device_by_node at least for platform devices. Perhaps
rework that to be "struct device *of_find_bus_device_by_node(struct
bus_type *b, struct device_node *np)" and then wrappers for each bus
type. And perhaps make a class variant as well. However, we should
also consider if OF is the right level. Maybe it should be fwnode