Re: [PATCH] kernel/cpu.c: fix many errors related to style.

From: Joe Perches
Date: Sat May 06 2017 - 11:28:08 EST


On Sat, 2017-05-06 at 17:09 +0200, Matej Dujava wrote:
> This patch fixes the checkpatch.pl warning:
> ERROR: spaces required around that '=' (ctx:VxW)
> WARNING: Block comments use a trailing */ on a separate line
> CHECK: Please don't use multiple blank lines
> CHECK: Blank lines aren't necessary before a close brace '}'
> CHECK: braces {} should be used on all arms of this statement
> CHECK: Blank lines aren't necessary after an open brace '{'
[]
> diff --git a/kernel/cpu.c b/kernel/cpu.c

Please don't modify core kernel files just to shut-up checkpatch
messages. If you are doing rework, it makes some sense, otherwise
it doesn't add much value.

> - /* Entry state on starting. Interrupts enabled from here on. Transient
> - * state for synchronsization */
> + /*
> + * Entry state on starting. Interrupts enabled from here on. Transient
> + * state for synchronsization

Fixing typos would be nicer than merely reformatting comments.