Re: Resizeable PCI BAR support v5

From: Andy Shevchenko
Date: Sun May 07 2017 - 19:59:15 EST

On Thu, May 4, 2017 at 12:31 PM, Christian KÃnig
<deathsimple@xxxxxxxxxxx> wrote:
> Hi everyone,
> this is the fifth incarnation of this set of patches. It enables device
> drivers to resize and most likely also relocate the PCI BAR of devices
> they manage to allow the CPU to access all of the device local memory at once.
> This is very useful for GFX device drivers where the default PCI BAR is only
> about 256MB in size for compatibility reasons, but the device easily have
> multiple gigabyte of local memory.
> Noteable changed compared to v4:
> 1. Patch #1 is new and a minor cleanup to the PCI code.
> 2. Some more helpers added to patch #2
> 3. We now print a note to syslog before releasing resources.
> 4. Add defines for registers and bits used to add new root hub window.
> I've addressed mostly every review comment I've got so far and it looks like we
> are getting closer to landing this. Any more suggestions/hints how we could
> improve the patchset would be very welcome.

Thanks for an update.

I'm going to comment individual patches.

Just for the future, please use versioning in the patches themselves
(hint: -vX to git-format-patch).

With Best Regards,
Andy Shevchenko