Re: [PATCH] perf, tools: Support srccode output

From: Jiri Olsa
Date: Tue May 09 2017 - 05:06:43 EST


On Mon, May 08, 2017 at 01:22:05PM -0700, Andi Kleen wrote:

SNIP

> diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
> index df051a52393c..542bfa7db53c 100644
> --- a/tools/perf/util/srcline.c
> +++ b/tools/perf/util/srcline.c
> @@ -479,6 +479,35 @@ char *__get_srcline(struct dso *dso, u64 addr, struct symbol *sym,
> return srcline;
> }
>
> +/* Returns filename and fills in line number in line */
> +char *get_srcline_split(struct dso *dso, u64 addr,
> + bool unwind_inlines, unsigned *line)

no need to pass unwind_inlines as arg if it's always true

jirka