Re: [PATCH] asm-generic/io.h: remove unnecessary #include of <linux/vmalloc.h>

From: kbuild test robot
Date: Tue May 09 2017 - 08:02:15 EST


Hi Tobias,

[auto build test ERROR on v4.9-rc8]
[also build test ERROR on next-20170509]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Tobias-Klauser/asm-generic-io-h-remove-unnecessary-include-of-linux-vmalloc-h/20170509-184856
config: arm-sunxi_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm

All errors (new ones prefixed by >>):

drivers/clk/sunxi-ng/ccu_reset.h:28:41: sparse: expected ; at end of declaration
drivers/clk/sunxi-ng/ccu_reset.h:28:41: sparse: Expected } at end of struct-union-enum-specifier
drivers/clk/sunxi-ng/ccu_reset.h:28:41: sparse: got *
drivers/clk/sunxi-ng/ccu_reset.h:31:1: sparse: Expected ; at the end of type declaration
drivers/clk/sunxi-ng/ccu_reset.h:31:1: sparse: got }
drivers/clk/sunxi-ng/ccu_reset.h:35:16: sparse: no member 'rcdev' in struct ccu_reset
drivers/clk/sunxi-ng/ccu_reset.h:35:16: sparse: unknown member
drivers/clk/sunxi-ng/ccu_reset.h:35:16: sparse: cast from unknown type
drivers/clk/sunxi-ng/ccu_reset.c:24:9: sparse: undefined identifier 'spin_lock_irqsave'
drivers/clk/sunxi-ng/ccu_reset.c:29:9: sparse: undefined identifier 'spin_unlock_irqrestore'
drivers/clk/sunxi-ng/ccu_reset.h:35:16: sparse: incompatible types for operation (-)
drivers/clk/sunxi-ng/ccu_reset.h:35:16: left side has type char *<noident>
drivers/clk/sunxi-ng/ccu_reset.h:35:16: right side has type bad type
drivers/clk/sunxi-ng/ccu_reset.c:42:9: sparse: undefined identifier 'spin_lock_irqsave'
drivers/clk/sunxi-ng/ccu_reset.c:47:9: sparse: undefined identifier 'spin_unlock_irqrestore'
In file included from drivers/clk/sunxi-ng/ccu_reset.c:14:0:
>> drivers/clk/sunxi-ng/ccu_reset.h:28:2: error: unknown type name 'spinlock_t'
spinlock_t *lock;
^~~~~~~~~~
drivers/clk/sunxi-ng/ccu_reset.c: In function 'ccu_reset_assert':
>> drivers/clk/sunxi-ng/ccu_reset.c:24:2: error: implicit declaration of function 'spin_lock_irqsave' [-Werror=implicit-function-declaration]
spin_lock_irqsave(ccu->lock, flags);
^~~~~~~~~~~~~~~~~
>> drivers/clk/sunxi-ng/ccu_reset.c:29:2: error: implicit declaration of function 'spin_unlock_irqrestore' [-Werror=implicit-function-declaration]
spin_unlock_irqrestore(ccu->lock, flags);
^~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/spinlock_t +28 drivers/clk/sunxi-ng/ccu_reset.h

1d80c142 Maxime Ripard 2016-06-29 22 };
1d80c142 Maxime Ripard 2016-06-29 23
1d80c142 Maxime Ripard 2016-06-29 24
1d80c142 Maxime Ripard 2016-06-29 25 struct ccu_reset {
1d80c142 Maxime Ripard 2016-06-29 26 void __iomem *base;
1d80c142 Maxime Ripard 2016-06-29 27 struct ccu_reset_map *reset_map;
1d80c142 Maxime Ripard 2016-06-29 @28 spinlock_t *lock;
1d80c142 Maxime Ripard 2016-06-29 29
1d80c142 Maxime Ripard 2016-06-29 30 struct reset_controller_dev rcdev;
1d80c142 Maxime Ripard 2016-06-29 31 };
1d80c142 Maxime Ripard 2016-06-29 32
1d80c142 Maxime Ripard 2016-06-29 33 static inline struct ccu_reset *rcdev_to_ccu_reset(struct reset_controller_dev *rcdev)
1d80c142 Maxime Ripard 2016-06-29 34 {
1d80c142 Maxime Ripard 2016-06-29 @35 return container_of(rcdev, struct ccu_reset, rcdev);
1d80c142 Maxime Ripard 2016-06-29 36 }
1d80c142 Maxime Ripard 2016-06-29 37
1d80c142 Maxime Ripard 2016-06-29 38 extern const struct reset_control_ops ccu_reset_ops;

:::::: The code at line 28 was first introduced by commit
:::::: 1d80c14248d6082c91a8a9e3d70cc94c3cc18ecb clk: sunxi-ng: Add common infrastructure

:::::: TO: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
:::::: CC: Michael Turquette <mturquette@xxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip