Re: [PATCH 1/2] of: remove extraneous 'const' in typedef

From: Arnd Bergmann
Date: Thu May 11 2017 - 11:04:00 EST


On Thu, May 11, 2017 at 4:44 PM, Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> On Thu, May 11, 2017 at 7:24 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>> One change that was meant to address a sparse warning turned out
>> to cause hundreds of new gcc-7 warnings:
>
> I guess you are the only one on gcc-7.

It was just released last week or so. I actually had been using it for
a while but accidentally disabled a lot of the warning output until now
some others started using it too and asked me about it.

>> include/linux/of_irq.h:11:13: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
>>
>> After reverting the change, the gcc warnings are gone again, and I
>> can't reproduce the sparse warnings either.
>
> Humm, maybe different sparse versions? I'm on 0.5.0.

I have v0.5.0-183-gfbbfc73. To clarify, I did not get a sparse warning after my
patch, I did not try reverting your patch first.

Arnd