Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

From: Arnd Bergmann
Date: Fri May 12 2017 - 04:20:52 EST


On Fri, May 12, 2017 at 10:11 AM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> Anyway, what's special about modules? IDGI...

One of the arguments that came up earlier was code in external modules
being mostly unaudited, sometimes without any source code available
at all but still used in devices.

If modules can't do set_fs() any more, this could eliminate bugs with
unpaired set_fs in those modules.

Limiting factors of course are:

- embedded systems that ship come with their own kernels (as opposed
to using whatever users have, or relying on binary distros) can just
make it available to modules again, by reverting the patch

- As Christoph said, they could have an open-coded set_fs in the
driver

- Whatever other method a clueless driver write might come up with
isn't necessarily better than set_fs().

Arnd