Re: [PATCH 4.4 38/60] USB: serial: sierra: fix bogus alternate-setting assumption

From: Greg Kroah-Hartman
Date: Fri May 12 2017 - 09:10:37 EST


On Fri, May 12, 2017 at 02:14:03PM +0200, Johan Hovold wrote:
> On Fri, May 12, 2017 at 12:26:17PM +0100, Ben Hutchings wrote:
> > On Thu, 2017-05-11 at 16:13 +0200, Greg Kroah-Hartman wrote:
> > > 4.4-stable review patch. If anyone has any objections, please let me know.
> > >
> > > ------------------
> > >
> > > From: Johan Hovold <johan@xxxxxxxxxx>
> > >
> > > commit 16620b483eaf7750413bae472f4363b6b959fcaa upstream.
> > >
> > > Interface numbers do not change when enabling alternate settings as
> > > comment and code in this driver suggested.
> > >
> > > Remove the confusing comment and redundant retrieval of the interface
> > > number in probe, while simplifying and renaming the interface-number
> > > helper.
> >
> > This looks like cleanup with no functional impact, so unless it's needed
> > as preparation for something else I think it should be dropped.
>
> Indeed, this one is not needed in -stable.

Ah, my fault, I thought this was fixing an issue there, sorry about
that.

Now removed from all of the queues, thanks Ben.

greg k-h