Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers

From: Kishon Vijay Abraham I
Date: Tue May 16 2017 - 06:12:20 EST


Hi Vivek,

On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote:
> Adding vendor specific directories in phy to group
> phy drivers under their respective vendor umbrella.
>
> Also updated the MAINTAINERS file to reflect the correct
> directory structure for phy drivers.
>
> Signed-off-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>
> Acked-by: Heiko Stuebner <heiko@xxxxxxxxx>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> Reviewed-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> Cc: Kishon Vijay Abraham I <kishon@xxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> Cc: Chen-Yu Tsai <wens@xxxxxxxx>
> Cc: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> Cc: Stephen Boyd <stephen.boyd@xxxxxxxxxx>
> Cc: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> Cc: linux-usb@xxxxxxxxxxxxxxx
> ---
>
> Changes since v4:
> - Reprepared the patch based on latest torvalds/master.
> - Added new directory for amlogic, since there's a new patch [1]
> coming in for amlogic platforms.
>
> Changes since v3:
> - Added 'Acked-by' and 'Reviewed by' tags received for this patch.
> - No functional change.
>
> Changes since v2:
> - Rebased on linux-phy/next.
> - Took care of drivers added/removed for each vendors since v2.
> - Updated the 'Signed-off-by' tag with my current email id.
>
> Changes from v1:
> - Updated the MAINTAINERS file to reflect the same change
> in directory structure.
> - Removed PHY_PLAT config as pointed out by Kishon.
> So we don't require the second patch in the v1 of this series:
> [PATCH 2/2] arm: mach-spear: Enable PHY_PLAT to meet dependency
> - Renamed sunxi --> allwinner; rcar --> renesas.
> - Fixed error coming with qcom Makefile.
>
> * Build tested multi_v7_defconfig.
> * Build tested arm64 defconfig with all the involved configs enabled.
>
> [1] https://patchwork.kernel.org/patch/9684303/
>
.
.
<snip>
.
.
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index afaf7b643eeb..b353ac603ea0 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -15,73 +15,6 @@ config GENERIC_PHY
> phy users can obtain reference to the PHY. All the users of this

.
.
<snip>
.
.
> -
> +menu "Platform Phy drivers"

I don't think creating a new menu is required. I removed it and merged into
linux-phy.

Thanks
Kishon