Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register support

From: Nikita Yushchenko
Date: Tue May 16 2017 - 07:08:21 EST


> @@ -2000,6 +2007,7 @@ static int lpuart_probe(struct platform_device *pdev)
> }
> sport->port.line = ret;
> sport->lpuart32 = sdata->is_32;
> + lpuart_is_be = sdata->is_be;

Setting a global variable in per-device routine is quite bad design.