Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register support
From: Nikita Yushchenko
Date: Wed May 17 2017 - 01:43:43 EST
>>> @@ -2000,6 +2007,7 @@ static int lpuart_probe(struct platform_device *pdev)
>>> sport->port.line = ret;
>>> sport->lpuart32 = sdata->is_32;
>>> + lpuart_is_be = sdata->is_be;
>> Setting a global variable in per-device routine is quite bad design.
> There is a reason for that we don't want to change the exist
> lpuart32_read[write] API which is widely used in driver.
> Making a global lpuart_is_be is the simplest way to do it.
> Any strong blocking reason?
Code should be consistent.
There is no good reason to have sport->lpuart32 inside sport, but
lpuart_is_be outside of it. Both these values describe properties of
particular device, and thus should be in per-device structure.
If that implies adding sport arg to lpuart32_(read|write), just do that.