Re: [PATCH] Use device_property_read instead of of_property_read in the dw_mmc driver

From: David Woods
Date: Wed May 17 2017 - 18:07:42 EST

On 05/15/2017 09:30 AM, Andy Shevchenko wrote:
On Mon, May 15, 2017 at 12:36 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
On 25 April 2017 at 17:39, David Woods <dwoods@xxxxxxxxxxxx> wrote:
Using the device_property interfaces allows the dw_mmc driver to work
on platforms which run on either device tree or ACPI.
Can you please split this to two separate changes. One for dw_mmc with
a proper prefix (mmc: dw_mmc:) and one for the mmc core (prefix "mmc:

Yes, I will do that.

Btw, for the core part of change I would recommend to check other API
functions which might go slightly different in case of ACPI vs DT vs
built-in device properties.

For example, if any code is using of_gpio header and of_ related stuff
it should be rethought as well (not sure if we would change there
anything, though worth to double check).

I have not purged all references to of_ APIs from the core code. However, the ones which remain are specific to hardware I don't have, so I wouldn't be able to test those code paths. Btw, there is no good reason I can see to include of_gpio.h here, none of those interfaces seem to be used.

-David Woods