Re: [PATCH] crypto: hifn_795x: Fix a handful of minor bugs spotted by eye
From: Logan Gunthorpe
Date: Wed May 17 2017 - 23:33:53 EST
On 17/05/17 09:26 PM, Herbert Xu wrote:
> On Thu, May 18, 2017 at 11:25:06AM +0800, Herbert Xu wrote:
>> On Fri, Apr 28, 2017 at 11:02:40AM -0600, Logan Gunthorpe wrote:
>>> * Cleaned up the formatting of ablkcipher_get arguments so it complies
>>> with kernel style
>>> * The offset in ablkcipher_get sould be added to the source, not the
>>> destination. We rename it to soffset for clarity.
>>> * dst++ should be dst=sg_next(dst)
>>> * We call kunmap_atomic earlier so we only have to do it once.
>>> * If ablkcipher_get fails, we should probably ensure the request
>>> completes with an error.
>> Please don't mix unrelated changes in the same patch.
Seriously? The patch is tiny and those are all incredibly minor changes.
>> Also was this tested on actual hardware? This is an old driver so
>> it's probably best to just let it be.
No, I don't have that hardware. I sent this patch because you requested it.
> Of course we do want fix the offset issue so could you please send
> a new patch with just that fix?
Sorry, no, I honestly don't see that as worth my time. Feel free to drop
the patch or roll your own.