Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for Altera FPGAs

[Anatolij Gustschin]

Hi,

On Wed, 17 May 2017 20:23:41 +0200
Anatolij Gustschin agust@xxxxxxx wrote:
...
>+	conf->spi = spi;
>+	conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_HIGH);

we should use GPIOD_OUT_LOW flags here. nCONFIG is low active, so
setting logical high will enable the signal (drive the pin low),
resulting in configuration reset for already initialised FPGAs when
loading/reloading the module.

Thanks,

Anatolij