Re: [PATCH] net: sched: fix a use-after-free error on chain on the error exit path

From: David Miller
Date: Thu May 18 2017 - 11:31:43 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Thu, 18 May 2017 15:07:02 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Set chain to null after the call to tcf_chain_destroy so that we don't
> call tcf_chain_put on the error exit path, thus avoiding a use-after-free
> error.
>
> Detected by CoverityScan, CID#1436357 ("Use after free")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Colin, you really need to make some adjustments to how you are submitting
these kinds of patches.

First of all, you must indicate the target tree in your Subject line
as "[PATCH net-next] " in this case.

Also, you need to add an appropriate Fixes: tag right before your
signoff.

Thank you.