Re: [RFC PATCH v2 10/17] cgroup: Make debug cgroup support v2 and thread mode
From: Waiman Long
Date: Thu May 18 2017 - 11:58:51 EST
On 05/17/2017 05:43 PM, Tejun Heo wrote:
> On Mon, May 15, 2017 at 09:34:09AM -0400, Waiman Long wrote:
>> Besides supporting cgroup v2 and thread mode, the following changes
>> are also made:
>> 1) current_* cgroup files now resides only at the root as we don't
>> need duplicated files of the same function all over the cgroup
>> 2) The cgroup_css_links_read() function is modified to report
>> the number of tasks that are skipped because of overflow.
>> 3) The relationship between proc_cset and threaded_csets are displayed.
>> 4) The number of extra unaccounted references are displayed.
>> 5) The status of being a thread root or threaded cgroup is displayed.
>> 6) The current_css_set_read() function now prints out the addresses of
>> the css'es associated with the current css_set.
>> 7) A new cgroup_subsys_states file is added to display the css objects
>> associated with a cgroup.
>> 8) A new cgroup_masks file is added to display the various controller
>> bit masks in the cgroup.
>> Signed-off-by: Waiman Long <longman@xxxxxxxxxx>
> As noted before, please make it clear that this is a debug feature and
> not expected to be stable. Also, I don't see why this and the
> previous two patches are in this series. Can you please split these
> out to a separate patchset?
Sure. I can separate out the debug code into a separate patchset. It is
just easier to manage as a single patchset than 2 separate ones.