Re: [PATCH] efi-pstore: Fix read iter after pstore API refactor

From: Kees Cook
Date: Thu May 18 2017 - 12:42:04 EST


On Thu, May 18, 2017 at 9:18 AM, Ard Biesheuvel
<ard.biesheuvel@xxxxxxxxxx> wrote:
> On 18 May 2017 at 14:01, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>> On Thu, May 18, 2017 at 3:35 AM, Ard Biesheuvel
>> <ard.biesheuvel@xxxxxxxxxx> wrote:
>>> On 12 May 2017 at 22:58, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>>>> During the internal pstore API refactoring, the EFI vars read entry was
>>>> accidentally made to update a stack variable instead of the pstore
>>>> private data pointer. This corrects the problem (and removes the now
>>>> needless argument).
>>>>
>>>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>>
>>> Does this need a cc stable?
>>
>> No, the refactor first appeared in 4.12-rc1.
>>
>
> OK. Applied.

Err, eek, no, it's already gone into Linus's tree.

-Kees

--
Kees Cook
Pixel Security