Re: [linux-sunxi] [PATCH v6 9/9] arm64: allwinner: a64: enable Wi-Fi for Pine64

From: Chen-Yu Tsai
Date: Thu May 18 2017 - 23:02:10 EST


On Thu, May 18, 2017 at 3:16 PM, Icenowy Zheng <icenowy@xxxxxxx> wrote:
> The Wi-Fi module of Pine64 is powered via DLDO4 and ELDO1 (the latter
> one provides I/O voltage).
> Add device node for it.
> Although the Wi-Fi module is an external module which should be inserted
> to a header, according to my personal talk with TL Lim, he does not want
> this header to be used as GPIO (so it's with 2.0mm pitch, not 2.54mm as
> other GPIO headers).

The patch looks OK, but given the module is removable, I think it should be
an overlay. The overlay would enable WiFi + Bluetooth, and all the
peripherals needed to connect them.

That way, if the module is not installed, we avoid confusing the user with
unused peripherals, and avoid having live voltage on an unoccupied header.