Re: [PATCH v3 00/21] drm: sun4i: Add support for the HDMI controller

From: Chen-Yu Tsai
Date: Fri May 19 2017 - 03:35:03 EST

On Wed, May 17, 2017 at 3:40 PM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> Hi,
> Here is an attempt at getting the HDMI controller running.
> This HDMI controller is found on a number of old Allwinner SoCs (A10, A10s,
> A20, A31).
> This driver only supports for now the A10s because it was an easy target,
> being very close to the A13 that is already supported by our DRM driver.
> There's nothing out of the extraordinary there, except maybe the clock
> setup. All the internal clocks (TMDS, DDC) have been modeled using the
> common clock framework, the TMDS clock being the parent of the DDC one.
> While this might sound overkill, other SoC have a different, external
> source for the DDC clock, which will be easier to support through the clock
> framework.
> The IP also supports audio (through an already supported i2s controller,
> and some missing configuration in the HDMI controller) and CEC. Both will
> come eventually.
> Let me know what you think!
> Maxime
> Changes from v2:
> - Fixed the PLL control macros definitions
> - Called clk_enable / disable on the DDC clock
> - Added the flags to enable the connection polling
> - Fixed the vtotal computation in TCON's code, and added a comment
> - Added and documented the A10s display engine compatible
> - Reworked the component parsing code to bail out when a standard
> connector is found
> - Fixed a inconsistent comment in the predivider unapplication
> - Fixed a commit log
> - Added Chen-Yu's and Rob's Acked-By
> - Changed divider_round_rate to a static, inline function in the header
> - Added and document the A10s display pipeline compatible
> - Rebased on top of 4.12
> Changes from v1:
> - Fixed typos in the CCU header and the HDMI code
> - Reintroduced the comment for the backporch timings
> - Renamed the hdmi node to hdmi, instead of hdmi0
> - Added support for hdmi-connector
> - Added a separate Kconfig option for the HDMI support
> - Changed the TCON muxing configuration for an explicit call in the
> TCON's "clients"
> - Fixed the initialisation sequence that was clearing the clocks bits
> - Constified the HDMI's structures and removed whitespaces errors
> - Fixed an issue in the sunxi-ng code that was not reporting the proper
> parent clock rate if it was modified
> - Removed unused headers
> - Removed CLK_SET_RATE_PARENT for the DDC clock
> - Used the DDC address defines
> - Removed the interlace flag that wasn't supported at the moment
> - Moved most of the HDMI encoder init to the bind function like we do for
> the other encoders
> - Switched to drm_of_find_possible_crtcs
> - Removed the extra printk that were still in my code
> - Rebased on top of linux-next
> - Removed the patch changing the divider_round_rate prototype to
> introduce a new function instead that takes the parent clock to
> evaluate
> - Added a clk_set_rate for the hdmi module clock
> - Fixed the V_TOTAL TCON ch0 calculation to be consistent with ch1's
> - Defined all registers, and remove the TODOs
> - Fixed the EDID issues by increasing the timeout.
> - Added an atomic_check to prevent the DBLCLK modes to be used, as it is
> not supported yet
> - Updated the binding to add the interrupts and DMA channels
> Maxime Ripard (21):
> clk: divider: Make divider_round_rate take the parent clock
> clk: sunxi-ng: Pass the parent and a pointer to the clocks round rate
> clk: sunxi-ng: div: Switch to divider_round_rate
> clk: sunxi-ng: mux: Don't just rely on the parent for CLK_SET_RATE_PARENT
> clk: sunxi-ng: mux: split out the pre-divider computation code
> clk: sunxi-ng: mux: Change pre-divider application function prototype
> clk: sunxi-ng: mux: Re-adjust parent rate
> clk: sunxi-ng: sun5i: Export video PLLs

Merged patches 1 ~ 8 and ...

> drm/sun4i: tcon: Add channel debug
> drm/sun4i: tcon: Move the muxing out of the mode set function
> drm/sun4i: tcon: Switch mux on only for composite
> drm/sun4i: tcon: Fix tcon channel 1 backporch calculation
> drm/sun4i: tcon: Change vertical total size computation inconsistency
> drm/sun4i: tcon: multiply the vtotal when not in interlace
> drm/sun4i: Ignore the generic connectors for components
> dt-bindings: display: sun4i: Add HDMI display bindings
> dt-bindings: display: sun4i: Add allwinner,tcon-channel property
> drm/sun4i: Add HDMI support
> drm/sun4i: Add compatible for the A10s pipeline

> ARM: sun5i: a10s: Add the HDMI controller node
> ARM: sun5i: a10s-olinuxino: Enable HDMI

... 20 ~ 21 for 4.13.