Re: [PATCH] firmware: ti_sci: fix strncat length check
From: Arnd Bergmann
Date: Fri May 19 2017 - 04:32:28 EST
On Tue, Mar 14, 2017 at 10:19 PM, santosh.shilimkar@xxxxxxxxxx
> On 3/14/17 2:11 PM, Arnd Bergmann wrote:
>> gcc-7 notices that the length we pass to strncat is wrong:
>> drivers/firmware/ti_sci.c: In function 'ti_sci_probe':
>> drivers/firmware/ti_sci.c:204:32: error: specified bound 50 equals the
>> size of the destination [-Werror=stringop-overflow=]
>> Instead of the total length, we must pass the length of the
>> remaining space here.
>> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control
>> Interface (TI-SCI) protocol")
>> Acked-by: Nishanth Menon <nm@xxxxxx>
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>> Originally submitted on Jan 11, patch is still needed on Linux-4.11-rc2.
> Looks fine to me Arnd. Will you be applying it to SOC driver branch ?
> Acked-by: Santosh Shilimkar <ssantosh@xxxxxxxxxx>
For some reason I dropped the ball in this patch, applied to arm-soc fixes
now and marked for stable backports.